This page is no longer maintained — Please continue to the home page at www.scala-lang.org

Fix to fjbg, do I need to replace starr?

2 replies
gkossakowski
Joined: 2010-03-11,
User offline. Last seen 33 weeks 5 days ago.
Hi,
I have a bug-fix that touches src/fjbg. I'm wondering what I should do once I implement my fix? Should I rebuild a whole new starr so those changes are propagated to lib/fjbg.jar file?
I was thinking about just rebuilding fjbg.jar using 'libs.fjbgpack' target and copying it manually to lib directory. My change is binary compatible so I don't think it would cause any problems. Thoughts?

--
Grzegorz Kossakowski

extempore
Joined: 2008-12-17,
User offline. Last seen 35 weeks 3 days ago.
Re: Fix to fjbg, do I need to replace starr?

On Wed, Feb 1, 2012 at 5:44 AM, Grzegorz Kossakowski
wrote:
> I have a bug-fix that touches src/fjbg. I'm wondering what I should do once
> I implement my fix? Should I rebuild a whole new starr so those changes are
> propagated to lib/fjbg.jar file?
>
> I was thinking about just rebuilding fjbg.jar using 'libs.fjbgpack' target
> and copying it manually to lib directory. My change is binary compatible so
> I don't think it would cause any problems. Thoughts?

All you need to do is replace fjbg.jar with your updated one, and then
run ./push-binary-libs.sh (with arguments of username and password
which allow you to push to artifactory - jsuereth can give you those
if you don't have them.) After that you will notice the
fjbg.sha1.desired file has been updated, at which point you can check
that in, and once it is merged into trunk future people will pull the
new fjbg.jar.

Those future people will have to run pull-binary-libs.sh manually to
get the update (or maybe it works automatically if you use sbt, but
I'm still on ant, where it will notice a change to scala-compiler.jar
and pull new libs, but not to anything else because it is comically
challenging to write a conditional like if "a or b or c" in antese.)

gkossakowski
Joined: 2010-03-11,
User offline. Last seen 33 weeks 5 days ago.
Re: Fix to fjbg, do I need to replace starr?
On 1 February 2012 16:30, Paul Phillips <paulp [at] improving [dot] org> wrote:
On Wed, Feb 1, 2012 at 5:44 AM, Grzegorz Kossakowski
<grzegorz [dot] kossakowski [at] gmail [dot] com> wrote:
> I have a bug-fix that touches src/fjbg. I'm wondering what I should do once
> I implement my fix? Should I rebuild a whole new starr so those changes are
> propagated to lib/fjbg.jar file?
>
> I was thinking about just rebuilding fjbg.jar using 'libs.fjbgpack' target
> and copying it manually to lib directory. My change is binary compatible so
> I don't think it would cause any problems. Thoughts?

All you need to do is replace fjbg.jar with your updated one, and then
run ./push-binary-libs.sh (with arguments of username and password
which allow you to push to artifactory - jsuereth can give you those
if you don't have them.) After that you will notice the
fjbg.sha1.desired file has been updated, at which point you can check
that in, and once it is merged into trunk future people will pull the
new fjbg.jar.

Those future people will have to run pull-binary-libs.sh manually to
get the update (or maybe it works automatically if you use sbt, but
I'm still on ant, where it will notice a change to scala-compiler.jar
and pull new libs, but not to anything else because it is comically
challenging to write a conditional like if "a or b or c" in antese.)

Thanks. A pull request will follow shortly.
Regarding the fact that people might not have updated fjbg.jar file. It's not a terrible situation because it's going to only affect those that use -Yvirtpatmat and happen to have pattern exactly like this:
(x: Int) match {  case _ => ... }
(with no other cases defined)
You can see we I don't need to worry about it too much.

--
Grzegorz Kossakowski

Copyright © 2012 École Polytechnique Fédérale de Lausanne (EPFL), Lausanne, Switzerland