Submitting a patch

What's the preferred way to submit a patch for the compiler?

I have a combined fix for:

SI-5040 Behaviour of scala.Dynamic depends on implementation details
of superclasses
SI-5039 scala.Dynamic documentation is incorrect
SI-4536 Dynamic is broken.

Should I post a patch in Jira or should I rather use github?

Re: Submitting a patch

Added by extempore on 2011-10-01, 04:07

On Fri, Sep 30, 2011 at 7:53 PM, Jordi Salvat i Alabart
wrote:
> Should I post a patch in Jira or should I rather use github?

Github. Also you could make my life a lot easier by being sure to
include test cases and by making sure the test suite passes. (Maybe
this sounds obvious, but at least 80% of patches submitted do not
compile, have no tests, and/or break tests.)

Re: Submitting a patch

Added by Jordi Salvat i Alabart on 2011-10-01, 04:17

It is obvious to me...

But I've been hiring in my team and only 2 candidates out of about 25
I've phone-screened had ever used unit tests in real life. I'm
disappointed that the scala world is not any better than PHP :-(

On 1 Oct, 04:57, Paul Phillips wrote:
> On Fri, Sep 30, 2011 at 7:53 PM, Jordi Salvat i Alabart
>
> wrote:
> > Should I post a patch in Jira or should I rather use github?
>
> Github.  Also you could make my life a lot easier by being sure to
> include test cases and by making sure the test suite passes.  (Maybe
> this sounds obvious, but at least 80% of patches submitted do not
> compile, have no tests, and/or break tests.)

Copyright © 2013 École Polytechnique Fédérale de Lausanne (EPFL), Lausanne, Switzerland